docs icon indicating copy to clipboard operation
docs copied to clipboard

Add WG leads to docs approvers

Open pierDipi opened this issue 1 year ago • 9 comments

Every time there is a new page added, I cannot approve PRs (example https://github.com/knative/docs/pull/5916), so I'm adding WG leads to the top-level directory approvers

pierDipi avatar May 13 '24 10:05 pierDipi

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pierDipi Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar May 13 '24 10:05 knative-prow[bot]

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
Latest commit 65354fef8f37fd6e6b3e57d8e9bb1622422c7ef1
Latest deploy log https://app.netlify.com/sites/knative/deploys/6641e86d322c5c00087b64ed
Deploy Preview https://deploy-preview-5968--knative.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar May 13 '24 10:05 netlify[bot]

/cc @knative/technical-oversight-committee

pierDipi avatar May 13 '24 10:05 pierDipi

/assign @knative/technical-oversight-committee

pierDipi avatar May 13 '24 10:05 pierDipi

If the issue is approving page changes, would it make sense to add the working group leads as owners on the config directory rather than for all of docs? Though given that there's no docs team right now, perhaps it's better to have more folks able to approve for the whole repo?

Yeah - let's subdivide the owners to the various sections

dprotaso avatar May 13 '24 17:05 dprotaso

@pierDipi can you update the PR?

dprotaso avatar Jun 04 '24 20:06 dprotaso

This Pull Request is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen with /reopen. Mark as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Sep 04 '24 01:09 github-actions[bot]

/remove-lifecycle stale

Cali0707 avatar Sep 04 '24 14:09 Cali0707

@pierDipi gentle ping

skonto avatar Sep 16 '24 13:09 skonto