docs
docs copied to clipboard
Add WG leads to docs approvers
Every time there is a new page added, I cannot approve PRs (example https://github.com/knative/docs/pull/5916), so I'm adding WG leads to the top-level directory approvers
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: pierDipi Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Deploy Preview for knative ready!
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | 65354fef8f37fd6e6b3e57d8e9bb1622422c7ef1 |
| Latest deploy log | https://app.netlify.com/sites/knative/deploys/6641e86d322c5c00087b64ed |
| Deploy Preview | https://deploy-preview-5968--knative.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
/cc @knative/technical-oversight-committee
/assign @knative/technical-oversight-committee
If the issue is approving page changes, would it make sense to add the working group leads as owners on the config directory rather than for all of docs? Though given that there's no docs team right now, perhaps it's better to have more folks able to approve for the whole repo?
Yeah - let's subdivide the owners to the various sections
@pierDipi can you update the PR?
This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.
/remove-lifecycle stale
@pierDipi gentle ping