docs icon indicating copy to clipboard operation
docs copied to clipboard

fixed the aligment of sponsor section

Open TenzDelek opened this issue 1 year ago • 8 comments

Changes: the current alignment of the sponsor seems to have no margin given resulting in default left and a negative white space. image

Changes made: made the sponsor section center to the screen for better white space. image

TenzDelek avatar May 11 '24 11:05 TenzDelek

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: TenzDelek Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar May 11 '24 11:05 knative-prow[bot]

Welcome @TenzDelek! It looks like this is your first PR to knative/docs 🎉

knative-prow[bot] avatar May 11 '24 11:05 knative-prow[bot]

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
Latest commit 8a2355ab8be993bbe6c68cf3b057783866a49999
Latest deploy log https://app.netlify.com/sites/knative/deploys/663f532fa889b2000866586e
Deploy Preview https://deploy-preview-5963--knative.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar May 11 '24 11:05 netlify[bot]

@TenzDelek I see the adopters are listed fine on https://knative.dev/docs/ page.

Can you check again please?

aliok avatar Jun 04 '24 20:06 aliok

@TenzDelek I see the adopters are listed fine on https://knative.dev/docs/ page.

Can you check again please?

hey @aliok , I have raised that issue in #5996 and from what I have seen, it is only happening for my device(window). but for my mac, it is working perfectly fine. I guess that problem resides from my end.. Thank you for the concern, this pr can be close :)

TenzDelek avatar Jun 05 '24 05:06 TenzDelek

@TenzDelek

Hm, interesting. Do you have anything special on your Windows machine? That shouldn't happen on Windows too

aliok avatar Jun 05 '24 08:06 aliok

@TenzDelek

Hm, interesting. Do you have anything special on your Windows machine? That shouldn't happen on Windows too

@aliok , I don't recall having any specific installation that might raise this behavior. but as per my discussion in the above issue section, other member who are having windows doesn't seem to have this kind of issue. so I guess technically this comes down to my machine. I will try to look further into it. but i find it funny how it only the marquee that is not working? is there any case regarding this in the pass? :)

TenzDelek avatar Jun 05 '24 09:06 TenzDelek

This Pull Request is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen with /reopen. Mark as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Sep 04 '24 01:09 github-actions[bot]