docs icon indicating copy to clipboard operation
docs copied to clipboard

Published 20 hours ago • verified publisher icon knative

Sample App: Code Clean up

Open Leo6Leo opened this issue 1 year ago • 2 comments
trafficstars

fixes #5950

We need to tidy up our sample app code! And because each component might be connected, it will be hard to make edit on different PR. Making this huge PR could make the life much easier.

This includes but not limited to:

  • Making sure all names (like variables and services) are consistent.
  • Checking that all code files are in the right folders.
  • Using the best coding practices.

Leo6Leo avatar Apr 24 '24 18:04 Leo6Leo

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
Latest commit 9e282e5836e5c2a7005924aaaac85def2570ff4d
Latest deploy log https://app.netlify.com/sites/knative/deploys/665645e3f619ec00089d08fe
Deploy Preview https://deploy-preview-5948--knative.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 24 '24 18:04 netlify[bot]

/cc @pierDipi @Cali0707 @creydr

Leo6Leo avatar May 27 '24 13:05 Leo6Leo

/lgtm /approve

pierDipi avatar May 29 '24 13:05 pierDipi

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leo6Leo, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar May 29 '24 13:05 knative-prow[bot]