docs icon indicating copy to clipboard operation
docs copied to clipboard

Update eventing OIDC docs that EKB supports OIDC

Open creydr opened this issue 1 year ago • 3 comments

Currently we list only that OIDC is supported in eventing-core with the MTChannelBasedBroker and InMemoryChannel. Since we have OIDC support in eventing-kafka-broker (EKB) too, we can add a support matrix in the OIDC docs, showing for which Broker classes / Broker implementations and Channels OIDC is supported (currently for the MTChannelBasedBroker, eventing-kafka-broker, InMemoryChannel and KafkaChannel).

In what release will this take happen (to the best of your knowledge)?

Ex. v1.14

Context

Project dashboard: https://github.com/orgs/knative/projects/66

Additional Information:

  • Current OIDC documenation: https://knative.dev/docs/eventing/experimental-features/sender-identity/
  • Eventing OIDC project: https://github.com/orgs/knative/projects/66/views/4
  • EKB issues for OIDC: https://github.com/orgs/knative/projects/66/views/4?filterQuery=repo%3A%22knative-extensions%2Feventing-kafka-broker%22
  • Useful links for Knative Docs style guide: https://github.com/knative/docs/blob/main/contribute-to-docs/README.md#style
  • Overview of Knative Docs Contributor guide: https://github.com/knative/docs/blob/main/contribute-to-docs/README.md

creydr avatar Feb 09 '24 08:02 creydr

I am interested in working on this. Could you please assign it to me?

UtkarshUmre avatar Feb 10 '24 07:02 UtkarshUmre

I am interested in working on this. Could you please assign it to me?

Hello @UtkarshUmre, great you're interested in taking this. You can assign the issue to yourself by commenting /assign. Also take a look at the following resources to get started with writing docs:

  • Knative Docs style guide: https://github.com/knative/docs/blob/main/contribute-to-docs/README.md#style
  • Overview of Knative Docs Contributor guide: https://github.com/knative/docs/blob/main/contribute-to-docs/README.md

/assign @UtkarshUmre

creydr avatar Feb 19 '24 08:02 creydr

Hey @UtkarshUmre, as I don't watch the PRs in knative/docs repository, feel free to ping me, when you have a PR up.

creydr avatar Feb 22 '24 15:02 creydr

Hello @UtkarshUmre, any updates on this? Anything we can help you with on this?

creydr avatar Feb 29 '24 12:02 creydr

Apologies for any inconvenience, but I'm currently occupied. Regrettably, I won't be able to address this issue.

UtkarshUmre avatar Feb 29 '24 18:02 UtkarshUmre

Apologies for any inconvenience, but I'm currently occupied. Regrettably, I won't be able to address this issue.

No problem. Thanks anyhow for offering help initially. I unassigned you, so somebody else can pick this up. Feel free to assign it to you again, when you have time.

creydr avatar Mar 01 '24 07:03 creydr

I am happy to take a look at this issue

jyizheng avatar Mar 10 '24 18:03 jyizheng

I am happy to take a look at this issue

Awesome @jyizheng. I am assigning this issue to you then. /assign @jyizheng

For future issues: you can assign to yourself, be simply commenting /assign

creydr avatar Mar 11 '24 06:03 creydr

Hey @jyizheng, any updates on this? Do you need any more information to get started with this?

creydr avatar Mar 18 '24 08:03 creydr

@jyizheng as I didn't hear anything back from you, I am unassigning you, to make this issue free for other contributors. Feel free to assign it back to you, in case you find time for it.

creydr avatar Apr 02 '24 09:04 creydr