docs icon indicating copy to clipboard operation
docs copied to clipboard

A local registry is no longer created by default.

Open gflarity opened this issue 1 year ago • 2 comments

There's a "bug" on this page:

https://knative.dev/docs/getting-started/quickstart-install/

kn quickstart kind will fail because registry is not created by default anymore.

Documentation fix:

kn quickstart kind --registry.

Looks like there's a whole process to contribute to docs, otherwise I would have just done that instead of filling a bug :)

gflarity avatar Nov 28 '23 20:11 gflarity

/assign

yanggangtony avatar Dec 05 '23 14:12 yanggangtony

@knative/client-writers can we handle this in kn? It seems odd to add this to the docs, if we always need --registry anyways.

ReToCode avatar Dec 06 '23 06:12 ReToCode

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Mar 06 '24 01:03 github-actions[bot]

cc @psschwei any thoughts here?

dprotaso avatar Mar 07 '24 21:03 dprotaso

I'd lean towards not having to require passing a flag for the default setup to work (sort of contradicts the name quickstart in that case....) and just fix kn quickstart kind so that it doesn't fail. There was a PR in flight to fix this (https://github.com/knative-extensions/kn-plugin-quickstart/pull/490#pullrequestreview-1847738384), but looks like it's stalled a bit. I'll see if I can find some free cycles to take a look at it.

psschwei avatar Mar 07 '24 22:03 psschwei

@dprotaso PR ^^^ should fix the issue without requiring any update to the docs.

psschwei avatar Mar 07 '24 23:03 psschwei

PR merged - going to close this out

dprotaso avatar Mar 07 '24 23:03 dprotaso