Fix issues in broker docs
PR fixes:
- some markdown syntax in the RabbitMQ Broker doc, so the code example is displayed properly (048ba6d8ae5beff5a01f6fc3ec84d223eca3224c)
- some broker spec indentation in the Broker configuration example (e9eb2d51d4a43f29d364ab419a2e13453884eebf)
- use correct target namespace for broker in broker configuration example, as the current namespace depends on the used kubeconfig context (6e41f0645d48cb2d4b381570c4b91d885c280e79)
- states support for RabbitMQ broker in configuration example (009f6d1bc8f06c8d45ee2e01a953eacbd7c3ac33)
Deploy Preview for knative ready!
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | 009f6d1bc8f06c8d45ee2e01a953eacbd7c3ac33 |
| Latest deploy log | https://app.netlify.com/sites/knative/deploys/6324704f245c9b0008038c35 |
| Deploy Preview | https://deploy-preview-5220--knative.netlify.app/docs/eventing/brokers/broker-developer-config-options |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
/lgtm /approve
/cherrypick release-1.7
@abrennan89: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you.
In response to this:
/cherrypick release-1.7
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: abrennan89, creydr
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~docs/eventing/OWNERS~~ [abrennan89]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@abrennan89: new pull request created: #5240
In response to this:
/cherrypick release-1.7
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
One comment - please check with someone in the Eventing WG that this is true about the broker, I always thought it was the current namespace the user is in, not the literal
defaultnamespace, but I might be wrong.
Yes, this is generally true, it's not the literal default but it is the default namespace in the context which is usually default but it might be differerent.
Otherwise lgtm! Happy to approve once this is confirmed.