knative
Using RPS as scaling metric always requires an annotation
Signed-off-by: Paul S. Schweigert [email protected]
Proposed Changes
Making it clear in the docs that when using RPS for autoscaling, users need to set the scaling metric annotation regardless of if the target is set per-revision or via the global configmap.
Issue surfaced in slack discussion
Deploy Preview for knative ready!
| Name | Link |
|---|---|
| Latest commit | ae4d1f7d4b7cef00161993142fbfc91c6c3b2c50 |
| Latest deploy log | https://app.netlify.com/sites/knative/deploys/6318b37ee45811000a135388 |
| Deploy Preview | https://deploy-preview-5209--knative.netlify.app/docs/serving/autoscaling/rps-target |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: abrennan89, psschwei
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~docs/serving/OWNERS~~ [abrennan89,psschwei]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![knative-prow[bot] avatar](https://avatars.githubusercontent.com/in/183726?v=4 "Published by a pub.dev verified publisher"){kind=small}
@abrennan89: new pull request created: #5236
In response to this:
/cherrypick release-1.7
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@abrennan89: new pull request created: #5237
In response to this:
/cherrypick release-1.6
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@abrennan89: new pull request created: #5238
In response to this:
/cherrypick release-1.5
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@abrennan89: new pull request created: #5239
In response to this:
/cherrypick release-1.4
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.