docs
docs copied to clipboard
Fixed markdown syntax in helloworld-java-spring/README.md
This PR fixes the syntax of code-samples/serving/hello-world/helloworld-java-spring/README.md, which is mixing Markdown and Asciidoc syntaxes.
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: hbelmiro / name: Helber Belmiro (bf85d69a192ed556c1e8956ea1b22ecbe341fdcd)
Deploy Preview for knative ready!
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | 50ab9e310e435dc31c756446a9dabd2d80654278 |
| Latest deploy log | https://app.netlify.com/sites/knative/deploys/630f86bb644c6c0008cd09e1 |
| Deploy Preview | https://deploy-preview-5164--knative.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Welcome @hbelmiro! It looks like this is your first PR to knative/docs 🎉
Hi @hbelmiro. Thanks for your PR.
I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@hbelmiro it's not actually asciidoc; we use Material for mkdocs to provide tabbed content. See https://squidfunk.github.io/mkdocs-material/reference/content-tabs/#grouping-code-blocks
Leaving this PR open until we decide whether to contain these code samples in the website or just the repo. For the website the == formatting would be valid. If it's just staying in the repo we can merge this PR.
/hold /ok-to-test
Leaving this PR open until we decide whether to contain these code samples in the website or just the repo. For the website the == formatting would be valid. If it's just staying in the repo we can merge this PR.
@abrennan89 We made the decision a while ago that it would be easier to maintain these code samples in GitHub and link out to them from the site. If you would like us to review this decision, we can discuss in the WG meeting.
Thanks for the review @snneji. I applied your suggestions.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: abrennan89, hbelmiro
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [abrennan89]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment