docs icon indicating copy to clipboard operation
docs copied to clipboard

Update the blog template to remove Hugo frontmatter

Open abrennan89 opened this issue 3 years ago • 5 comments

Expected Behavior

Blog template should reflect the format used here https://github.com/knative/docs/pull/5059/files

Actual Behavior

Blog template still includes old Hugo frontmatter. Leaving this in increases work for docs either during content reviews or afterwards if something is merged using this template and then needs to be cleaned up.

abrennan89 avatar Jul 14 '22 11:07 abrennan89

@abrennan89 Do you mean this template here: https://github.com/knative/docs/blob/main/contribute-to-docs/templates/template-blog-entry.md#copy-the-template

snneji avatar Aug 04 '22 11:08 snneji

No idea tbh, thought I saw an older one at one point with the hugo frontmatter but maybe it was somewhere else.

Either way, the one you're linking to looks like it's missing the author info, date etc and is different to what's actually being used in the docs as we decided a while back on the WG call, so either all the existing blogs need to be updated again to match this template, or the template should be updated to match what's actually used in practice.

I don't mind what we use as long as it's consistent and folks have a template that actually aligns with what's on the site.

abrennan89 avatar Aug 04 '22 15:08 abrennan89

@abrennan89, Do you think we should keep that table with tracking info about reviews and approvals? I'm not sure it's needed since reviews will be logged in GH.

snneji avatar Aug 05 '22 16:08 snneji

Nah I think it can be removed

abrennan89 avatar Aug 05 '22 16:08 abrennan89

@snneji it looks like the PR is opened against your fork instead of the docs repo. Would you mind fixing it and we can get this merged then? 🙂

abrennan89 avatar Aug 30 '22 19:08 abrennan89

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Nov 29 '22 01:11 github-actions[bot]

/remove-lifecycle stale

lance avatar Dec 06 '22 14:12 lance

/good-first-issue

evankanderson avatar Dec 08 '22 16:12 evankanderson

@evankanderson: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow[bot] avatar Dec 08 '22 16:12 knative-prow[bot]

Hi @abrennan89, I want to work on this issue

AmanSarraf avatar Feb 26 '23 16:02 AmanSarraf

/assign @AmanSarraf

AmanSarraf avatar Feb 26 '23 17:02 AmanSarraf

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar May 28 '23 01:05 github-actions[bot]

@AmanSarraf are you still working on this?

dprotaso avatar May 29 '23 13:05 dprotaso

/unassign @AmanSarraf

dprotaso avatar May 30 '23 13:05 dprotaso

/assign

lance avatar May 30 '23 15:05 lance