community icon indicating copy to clipboard operation
community copied to clipboard

Clarify for golang only doing hack

Open matzew opened this issue 1 year ago • 4 comments

Changes

  • based on discussion it feels that hack setup is useful for golang only - hence updating the template

/kind

Fixes #

Release Note


Docs


matzew avatar Oct 01 '24 07:10 matzew

@matzew: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • based on discussion it feels that hack setup is useful for golang only - hence updating the template

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow[bot] avatar Oct 01 '24 07:10 knative-prow[bot]

/approve /lgtm

/hold for Dave

dsimansk avatar Oct 01 '24 08:10 dsimansk

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Oct 01 '24 08:10 knative-prow[bot]

technically it's for anything - but the default ones are golang

you just need to include a bash function in your scripts to override it

eg. https://github.com/knative/hack/blob/fc6a8452af6d002ab7fb2818520a6f3d105ee1a0/presubmit-tests.sh#L179

dprotaso avatar Oct 04 '24 14:10 dprotaso

Closing as per above comment

dprotaso avatar Dec 29 '24 02:12 dprotaso