Add rhuss and dsimansk as approvers to all kn plugins

[aliok]

Changes

• Add rhuss and dsimansk as approvers to all kn plugins
• This is necessary to remove some inactive approvers later on

[knative-prow[bot]]

@aliok: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

• Add rhuss and dsimansk as approvers to all kn plugins
• This is necessary to remove some inactive approvers later on

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[aliok]

cc @rhuss @dsimansk

[rhuss]

/approve /lgtm

[knative-prow[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~peribolos/OWNERS~~ [aliok]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[knative-prow[bot]]

New changes are detected. LGTM label has been removed.

[psschwei]

Are Roland / David covered as members of client-writers? For example, on quickstart we've explicitly listed them as one of the owners: https://github.com/knative-extensions/kn-plugin-quickstart/blob/main/OWNERS#L4

[dprotaso]

Yeah let's update the OWNER files in the various repos to add client-writers

[psschwei]

I did a quick check of the kn-plugin repos and all looked to have client-writers in the owners file. So I think we're all good here.

[davidhadas]

Need rebase

[aliok]

I did a quick check of the kn-plugin repos and all looked to have client-writers in the owners file. So I think we're all good here.

Thanks for checking. I am closing this one then.

[aliok]

/close

[knative-prow[bot]]

@aliok: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[aliok]

Maybe I misunderstood...

Can you have a look at https://github.com/knative/community/blob/b056e6e06a8d413a1c40789d86199e592faccd80/peribolos/knative-extensions-OWNERS_ALIASES#L127-L129

Both names there are inactive and to be removed. Does that mean that leaving the group empty will work since rhuss and dsimansk are in the client-writers groups in all these repositories?

cc @dprotaso

[psschwei]

Does that mean that leaving the group empty will work since rhuss and dsimansk are in the client-writers groups in all these repositories?

Yes, that's right

[knative-prow-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.