community icon indicating copy to clipboard operation
community copied to clipboard

PROCESS CHANGE: WG leads should be in CNCF's maintainers.csv

Open aliok opened this issue 2 years ago • 5 comments

During https://github.com/knative/community/issues/945 I see TOC and SC members are added to the list in https://github.com/cncf/foundation/blob/main/project-maintainers.csv.

However, we should have more people there.

For example, Istio has different groups (https://github.com/cncf/foundation/blob/main/project-maintainers.csv#L1179):

  • Istio: Steering Committee
  • Istio: Technical Oversight Committee
  • Istio: Working Group Leads
  • Istio: Maintainers

We can go with the same structure.

Expected benefits

  • Rewarding the contributors by listing their name there
  • Being able to subscribe to maintainers-only things like some newsletters, etc.
  • Getting rid of the necessity to prove that I am actually a maintainer in Knative project.

Expected costs

  • More people are listed there - shouldn't cause any issue
  • Scripting change

UPDATE: see this comment: https://github.com/knative/community/issues/1383#issuecomment-1865809475 . We'll add WG leads and not all approvers.

aliok avatar Jun 15 '23 14:06 aliok

cc @knative/steering-committee

aliok avatar Jun 15 '23 14:06 aliok

Some notes:

  • If we go with this, SC wants to clean up the peribolos YAML file first as there are usernames there who haven't done any contributions for years
  • To remove people from peribolos, we need to define what are the criteria for that
  • @lance to lead the discussion for those criteria

Also, @csantanapr , it was mentioned that you might have an objection for this. Any comments?

Similarly, @puerco @nainaz @salaboy @nainaz , any comments?

aliok avatar Jul 03 '23 16:07 aliok

  • @lance to lead the discussion for those criteria

I've sent a PR with some language for removal - voluntary and not - in the ROLES.md document here: https://github.com/knative/community/pull/1390. Feedback is welcome - there are a few questions and consider it a WIP until we come to agreement.

lance avatar Jul 03 '23 19:07 lance

Update, in SC meeting, we had a vote and agreement for having WG leads in maintainers.csv file as well: https://docs.google.com/document/d/16Rpd2nhmLWrkFJUfpJ31Ox2PpultJ-bYIhqaiWQff_I/edit#bookmark=id.8jsaovwwr9fw

Not all approvers, but WG leads (in addition to SC+TOC members)

Updating the ticket description above.

aliok avatar Dec 21 '23 07:12 aliok

PR https://github.com/cncf/foundation/pull/720

aliok avatar Jan 12 '24 08:01 aliok