This repo contains golang and should be linted

Open krsna-m opened this issue 2 years ago • 5 comments

Look at knative/actions repo and use the reusable golang linter here.

Feb 14 '23 17:02 krsna-m

/assign @Bisht13

Feb 14 '23 23:02 Bisht13

@kvmware does this require only adding https://github.com/knative/actions/blob/main/.github/workflows/lint.yaml to this repo's GitHub workflows?

Feb 15 '23 00:02 Bisht13

@Bisht13 One would have to use the reusables (style). See how knative/serving is doing it. The lint.yaml is for the actions repo itself only. The reusable action should already check (double make sure please) that it only runs on golang code changes

Feb 15 '23 15:02 krsna-m

Is the reusable action able to handle repos with multiple go.mod files?

Feb 15 '23 22:02 dprotaso

Hmm the Lint action is not working on the actions repo due to a file rename. I will open an issue on the actions repo to address this

Feb 16 '23 04:02 kauana