community icon indicating copy to clipboard operation
community copied to clipboard

Published 20 hours ago • verified publisher icon knative

add myself as member

Open hueifeng opened this issue 2 years ago • 8 comments

hueifeng avatar Jun 11 '22 11:06 hueifeng

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: hueifeng / name: Huei Feng (ba3ee3926d1568fa12cec574df0eaa8974c69432)

linux-foundation-easycla[bot] avatar Jun 11 '22 11:06 linux-foundation-easycla[bot]

Welcome @hueifeng! It looks like this is your first PR to knative/community 🎉

knative-prow[bot] avatar Jun 11 '22 11:06 knative-prow[bot]

Hi @hueifeng. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow[bot] avatar Jun 11 '22 11:06 knative-prow[bot]

Hi @hueifeng

Please refer to the member ROLE and state in your first comment how you meet the requirement and the type of contributions you have made to Knative.

csantanapr avatar Jun 17 '22 00:06 csantanapr

/hold

csantanapr avatar Jun 17 '22 00:06 csantanapr

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, hueifeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Jun 30 '22 18:06 knative-prow[bot]

@evankanderson It looks like the do-not-merge/hold label cannot be automatically merged.

hueifeng avatar Jul 02 '22 16:07 hueifeng

@evankanderson It looks like the do-not-merge/hold label cannot be automatically merged.

@hueifeng could you please address https://github.com/knative/community/pull/1099#issuecomment-1158337234 by Carlos?

zroubalik avatar Jul 10 '22 11:07 zroubalik