client icon indicating copy to clipboard operation
client copied to clipboard

added include flags to include security context

Open EraKin575 opened this issue 1 year ago • 5 comments

Description

Changes

Reference

Fixes #1788

Release Note

made securityContext optional as a include flag


EraKin575 avatar Jun 22 '24 08:06 EraKin575

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: EraKin575 Once this PR has been reviewed and has the lgtm label, please assign maximilien for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Jun 22 '24 08:06 knative-prow[bot]

Hi @EraKin575. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow[bot] avatar Jun 22 '24 08:06 knative-prow[bot]

/ok-to-test

dsimansk avatar Jun 25 '24 08:06 dsimansk

@EraKin575: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
unit-tests_client_main 4f43783072ff5b3eb32e8848b821a7d67aef6858 link true /test unit-tests
build-tests_client_main 4f43783072ff5b3eb32e8848b821a7d67aef6858 link true /test build-tests
integration-tests-latest-release_client_main 4f43783072ff5b3eb32e8848b821a7d67aef6858 link true /test integration-tests-latest-release
integration-tests_client_main 4f43783072ff5b3eb32e8848b821a7d67aef6858 link true /test integration-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

knative-prow[bot] avatar Jun 25 '24 08:06 knative-prow[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

knative-prow-robot avatar Sep 05 '24 06:09 knative-prow-robot

This Pull Request is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen with /reopen. Mark as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Dec 05 '24 01:12 github-actions[bot]