client icon indicating copy to clipboard operation
client copied to clipboard

:broom: Dedup code by using client-pkg

Open cardil opened this issue 1 year ago • 5 comments

Changes

  • :broom: Dedup code by using client-pkg

Reference

Fixes knative-extensions/kn-plugin-event#282

cardil avatar Apr 16 '24 10:04 cardil

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

knative-prow[bot] avatar Apr 16 '24 10:04 knative-prow[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cardil Once this PR has been reviewed and has the lgtm label, please assign cali0707 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Apr 16 '24 10:04 knative-prow[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.03%. Comparing base (cbb6f5c) to head (d993c96). Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1935      +/-   ##
==========================================
+ Coverage   74.58%   78.03%   +3.45%     
==========================================
  Files         207      141      -66     
  Lines       15567     8770    -6797     
==========================================
- Hits        11611     6844    -4767     
+ Misses       3167     1271    -1896     
+ Partials      789      655     -134     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 16 '24 11:04 codecov[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow-robot avatar Apr 17 '24 15:04 knative-prow-robot

/hold /cc @dsimansk /cc @mvinkler

I think, I'll reconsider this in favor of another idea - to integrate all client code within knative/client itself, but with go modules. Probably some changes are needed for the release script, and some adjustment for Go 1.22 vendor changes, see: golang/go#60056

cardil avatar Apr 19 '24 08:04 cardil

This Pull Request is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen with /reopen. Mark as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Jul 19 '24 01:07 github-actions[bot]