Fix `kn service wait` for already ready ksvc

[dsimansk]

Description

Changes

• Fix kn service wait for already ready ksvc

Per the linked issue, the wait cmd doesn't react properly in case of KSVC is already ready when wait-loop is started. It's caused by lack of any new events from cluster to wait upon.

/cc @rhuss

Reference

Fixes #1922

Release Note

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.58%. Comparing base (8979cbd) to head (bd33cac). Report is 10 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1925   +/-   ##
=======================================
  Coverage   74.58%   74.58%           
=======================================
  Files         207      207           
  Lines       15563    15566    +3     
=======================================
+ Hits        11607    11610    +3     
  Misses       3167     3167           
  Partials      789      789           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[dsimansk]

/retest

[dsimansk]

@rhuss gentle reminder, PTAL. Thanks a lot!

[knative-prow[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [dsimansk,rhuss]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[dsimansk]

/override "Job style / suggester / github_actions"

[knative-prow[bot]]

@dsimansk: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:

• Job style / suggester / github_actions

Only the following failed contexts/checkruns were expected:

• EasyCLA
• build-tests_client_main
• integration-tests-latest-release_client_main
• integration-tests_client_main
• style / suggester / github_actions
• style / suggester / shell
• style / suggester / yaml
• tide
• unit-tests_client_main

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "Job style / suggester / github_actions"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dsimansk]

/override "style / suggester / github_actions"

[knative-prow[bot]]

@dsimansk: Overrode contexts on behalf of dsimansk: style / suggester / github_actions

In response to this:

/override "style / suggester / github_actions"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dsimansk]

/override "style / suggester / shell" /override "style / suggester / yaml"

[knative-prow[bot]]

@dsimansk: Overrode contexts on behalf of dsimansk: style / suggester / shell, style / suggester / yaml

In response to this:

/override "style / suggester / shell" /override "style / suggester / yaml"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dsimansk]

/retest