Added basic version of quiet mode to service create command

[sreeram-venkitesh]

Description

This PR was made as part of knative 48h hack. This is a proof of concept and there is no need to merge it until the work is complete.

Changes

• Added QuietMode flag to root command
• Used QuietMode flag to conditionally print/hide output for the kn service create command

Reference

Proof of concept for https://github.com/knative/client/issues/182

[knative-prow[bot]]

Welcome @sreeram-venkitesh! It looks like this is your first PR to knative/client 🎉

[knative-prow[bot]]

Hi @sreeram-venkitesh. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dsimansk]

/ok-to-test

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 79.19%. Comparing base (7b11654) to head (902dea9). Report is 23 commits behind head on main.

:exclamation: Current head 902dea9 differs from pull request most recent head ea2b02b. Consider uploading reports for the commit ea2b02b to get more accurate results

Files	Patch %	Lines
pkg/kn/commands/service/create.go	50.00%	1 Missing and 2 partials :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1904      +/-   ##
==========================================
- Coverage   79.20%   79.19%   -0.02%     
==========================================
  Files         180      180              
  Lines       14075    14081       +6     
==========================================
+ Hits        11148    11151       +3     
- Misses       2155     2156       +1     
- Partials      772      774       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[dsimansk]

It seems --quiet flag is conflicting in some of the unit tests. Aka it's working and discarding the outputs.

[knative-prow[bot]]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sreeram-venkitesh Once this PR has been reviewed and has the lgtm label, please ask for approval from dsimansk. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[sreeram-venkitesh]

/retest

[knative-prow[bot]]

@sreeram-venkitesh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
unit-tests_client_main	ea2b02b9a7c37fc6560f7df80f17b943b0ca8b28	link	true	/test unit-tests
integration-tests_client_main	ea2b02b9a7c37fc6560f7df80f17b943b0ca8b28	link	true	/test integration-tests
integration-tests-latest-release_client_main	ea2b02b9a7c37fc6560f7df80f17b943b0ca8b28	link	true	/test integration-tests-latest-release

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[github-actions[bot]]

This Pull Request is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen with /reopen. Mark as fresh by adding the comment /remove-lifecycle stale.

[sreeram-venkitesh]

/remove-lifecycle stale

[rhuss]

@sreeram-venkitesh I'm so sorry that I'm not able to work on these (and oer client-related) issues currently, because of other work assignments. I can't forsee when this will change, but maybe @dsimansk or others can help out ?

What are currently the next steps needed to get this landed ?