client
client copied to clipboard
Distinguish missing Serving/Eventing API from unsupported version
Description
Distinguish missing Serving/Eventing API from unsupported version
Changes
Reference
Fixes #1858
Release Note
Hi @xiangpingjiang. Thanks for your PR.
I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: xiangpingjiang Once this PR has been reviewed and has the lgtm label, please assign maximilien for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/ok-to-test
Codecov Report
Attention: Patch coverage is 44.00000% with 28 lines in your changes are missing coverage. Please review.
Project coverage is 79.49%. Comparing base (
f620968) to head (8bdc3fb). Report is 40 commits behind head on main.
| Files | Patch % | Lines |
|---|---|---|
| pkg/errors/factory.go | 15.15% | 27 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #1868 +/- ##
==========================================
- Coverage 79.62% 79.49% -0.14%
==========================================
Files 179 179
Lines 13927 13969 +42
==========================================
+ Hits 11090 11104 +14
- Misses 2070 2097 +27
- Partials 767 768 +1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/retest
This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.
/remove-lifecycle stale
This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.