client icon indicating copy to clipboard operation
client copied to clipboard

CLI: add support for experimental new filters API in trigger

Open Cali0707 opened this issue 2 years ago • 6 comments

Feature request

As part of preparing the experimental new filters API to Beta (tracked here: https://github.com/knative/eventing/issues/5204), we should add support to kn to create these filters when creating a trigger.

Use case

With the new filters API entering Beta, more users will want to try it out. It would be convenient for them if they can use kn to create them, instead of being required to use yaml files to try out the new filters.

UI Example

kn trigger create mytrigger --new-filter filtertype=filtervalue

Cali0707 avatar Jul 26 '23 15:07 Cali0707

@pierDipi @dsimansk @rhuss any thoughts on this?

Cali0707 avatar Jul 26 '23 16:07 Cali0707

@Cali0707 +1.

There's only support to display new filters, but not build/define. https://github.com/knative/client/pull/1794

Of course the tricky part is designing smooth UI elements for so many combinations possible.

dsimansk avatar Jul 27 '23 08:07 dsimansk

@Cali0707 +1.

There's only support to display new filters, but not build/define. #1794

Of course the tricky part is designing smooth UI elements for so many combinations possible.

+1, we can also consider not supporting everything in the CLI as a starting point and reconsider later

pierDipi avatar Jul 27 '23 09:07 pierDipi

Could be a good candidate for the 48h Knative hackathon.

rhuss avatar Sep 19 '23 14:09 rhuss

/assign

JuneOh710 avatar Nov 29 '23 20:11 JuneOh710

@dsimansk do you have a design/UI idea for this feature? In terms of what can be supported for the new trigger filters API?

pierDipi avatar Jun 20 '24 15:06 pierDipi