Track whitelist terminology in cobra etc.
The client is currently forced to use whitelist terminology due to dependencies
See: https://github.com/knative/client/blob/b916a5b3ed356ad8fd0cbd91fbe511765c231bcf/pkg/kn/commands/options/options.go#L40 https://github.com/knative/client/blob/4a3cf245504a71eccec0b681bfc053c291e1cee2/cmd/kn/main_test.go#L163 https://github.com/knative/client/blob/8f7088f0c013f583d05abfe78325e177720c3ba3/cmd/kn/main.go#L76 https://github.com/knative/client/blob/5ed353d36b2a98e83d480e9167a46feeb9459004/pkg/kn/config/config.go#L107
There's already upstream proposals to change those, so let's make sure we consume once ready https://github.com/spf13/pflag/pull/261.
@markusthoemmes thanks for the heads-up!
As the upstream PR is merged, let's update as soon as there is the next release.
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.
@markusthoemmes are you sure the reference to the upstream PR is correct ? It looks unrelated to this issue to me.
Fixed, thanks.
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.
/remove-lifecycle stale
I think it's a good point in time again to check whether Cobra has updated their code already and maybe find out or create an issue on the cobra tracker?