build-templates icon indicating copy to clipboard operation
build-templates copied to clipboard

Jib: Adds init script to use with any Gradle project.

Open coollog opened this issue 7 years ago • 3 comments

Fixes #63

The init script auto-applies jib-gradle-plugin to the Gradle project. Also fixes the caching for the jib-gradle BuildTemplate.

/cc @loosebazooka /cc @saturnism

coollog avatar Sep 13 '18 22:09 coollog

@coollog: GitHub didn't allow me to request PR reviews from the following users: loosebazooka.

Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Fixes #63

The init script auto-applies jib-gradle-plugin to the Gradle project. Also fixes the caching for the jib-gradle BuildTemplate.

/cc loosebazooka /cc saturnism

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow-robot avatar Sep 13 '18 22:09 knative-prow-robot

Hi @coollog. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow-robot avatar Sep 13 '18 22:09 knative-prow-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: coollog, saturnism To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: imjasonh

If they are not already assigned, you can assign the PR to them by writing /assign @imjasonh in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow-robot avatar Oct 29 '18 21:10 knative-prow-robot