Kailash Nadh comments

Results 672 comments of


                                            Kailash Nadh

feat: config to override env vars

Reviewed and added a few commits with minor cosmetic improvements and updated your branch. Please take a look and confirm, and then we're good to merge.

AWS AppConfig Deprecated API

Ah, was unaware of this. Looking forward to the PR. Thank you.

Lookup ASN and AS Name

Please feel free @Shivraj0.

Support Secure DNS (DoH, DoT, DoQ, DoH3)

dns.google.com is an HTTP service (which uses DNS underneath, that's all).

Fix sync.py (_make_poll) TypeError: Object of type TextWithEntities i…

Thanks for the PR @GoraPeak. Did this change from `.text` to `.text.text` in the Telethon API recently? Polls were working earlier.

Support for scientific names for vitamins

Hi @puranjay-dev. That's an nice idea. Please do send a PR. Let's do `dig vitamin.a @dns.toys`

Upgrade to v5.0.0 broken

@fullpwemium what Postgres version are you using? @lamurian the issue you described is normal behaviour. Upgrading listmonk requires running `./listmonk --upgrade`

Feature : Strong Data Validation

Hi @nayanthulkar28. Thanks for the PR. I'll review this closer to the 4.0.0 release (once the `multiuser` branch is merged).

Merging attributes instead of overwriting them, when importing subscribers

Recursively merging arbitrary attributes in the database, the `hobbies[]` array for example, is unfortunately not technically feasible.

Add Forward Email for smtp and bounce support

Thanks @shaunwarman. I've a local LLM script that translates missing strings. Will run that once this is merged. Will review this PR once v4.0.0 is done (as it has a...