omniauth-slack icon indicating copy to clipboard operation
omniauth-slack copied to clipboard

New Gem/Repo Owner

Open mikecx opened this issue 6 years ago • 17 comments

Not sure there's any non-rude way to handle this but would it be possible to hand the ownership of this Ruby Gem/repo over to someone else so that this gem can be maintained and updated? Thanks for considering!

mikecx avatar Jul 19 '18 21:07 mikecx

I think this is a reasonable request. While @kmrshntr and the others have created a wonderful gem, we have a community with a need for someone at the helm. I'm willing to collaborate with @kmrshntr and the other contributors to help update and maintain this library.

I created a fork of this gem a couple years ago to fix the bigger issues and to add some missing functionality. This has been working well for me and some others. You can see explanations of what I did in comments I left in the core slack.rb file. You can try out this fork in your own project with

gem 'omniauth-slack', github: 'ginjo/omniauth-slack'

EDIT: I just realized that my fork is not up-to-date with origin/master yet, so it is still using the older versions of omniauth-oauth2 and bundler. I'll update the fork with at least the gem spec changes.

ginjo avatar Jul 19 '18 23:07 ginjo

@ginjo Definitely appreciate your work on keeping it up to date in your fork! The company I work at has also suggested we can take it over and maintain it if no one else wants to. We ran into an issue when relying on this in another gem we were building. The older omniauth-oauth2 dependency created all sorts of fun since .gemspecs can't point to a fork/github. Downgrading our own gem to match felt wrong but it was the only way forward right now.

All that said, since this is a great and useful gem, i'd just love to see someone maintain it however that shapes up.

mikecx avatar Jul 19 '18 23:07 mikecx

Hi @mikecx, just FYI I've merged (or rebased really) the ginjo fork on top of @kmrshntr master. It contains fixes, updates, and documentation... But the biggest addition is support for workspace apps and tokens.

I can push this up to rubygems.org as ginjo-omniauth-slack, though I'm not too keen on cluttering the gem space. I would still prefer to work with the maintainers of this repo to get the ginjo fork (or any part of it) merged in :grinning: .

Meanwhile, if anyone wants to try it out:

gem 'omniauth-slack', git: 'https://github.com/ginjo/omniauth-slack'

ginjo avatar Aug 03 '18 01:08 ginjo

Just another FYI, I have released the ginjo fork as ginjo-omniauth-slack-2.4.0.gem on rubygems.org. See the readme and changelog for more info.

# Gemfile

gem 'ginjo-omniauth-slack'

@kmrshntr et al., still happy to help with the main repo any time.

ginjo avatar Aug 29 '18 00:08 ginjo

👏@ginjo

aguynamedben avatar Dec 07 '18 20:12 aguynamedben

@kmrshntr It would be really helpful to the community if you could do one final action and give @ginjo management of the repo. Or at least a deprecation warning in the repo description/README directing the community to rally behind ginjo-omniauth-slack. 🙏Thank you for the hard work you gave to this project.

aguynamedben avatar Dec 07 '18 20:12 aguynamedben

@ginjo Given the event-stream security fiasco, I'm just curious to understand where you work?

aguynamedben avatar Dec 07 '18 20:12 aguynamedben

God bless @mikecx for posting this. God bless @ginjo for the wonderful work he has done with the updates.

god avatar May 19 '20 06:05 god

@aguynamedben @ginjo I'm sorry I've abandoned this repository for so long. I may have been waiting for someone else to make this issue.

kmrshntr avatar Aug 12 '20 04:08 kmrshntr

@ginjo Should I transfer ownership? Or should I just add deprecation message to description/README.

kmrshntr avatar Aug 12 '20 04:08 kmrshntr

Hi @kmrshntr , great to hear from you! Just off the top of my head, I think transfer of ownership on rubygems.org (assuming that's possible) and a message on the README in your github repo would seem to make the most sense. But I'm open to whatever arrangement suits you and the community best.

And of course, if you want to maintain control, you're always welcome to incorporate any/all of my work into your repo. Just let me know what you prefer, and I'll work with you. Thanks!

ginjo avatar Aug 14 '20 05:08 ginjo

@aguynamedben , I appreciate your concern. I'm an independent contractor/consultant in the SF Bay Area. If anyone has any questions about my code, they are welcome to review and critique my repos and the published gems.

ginjo avatar Aug 14 '20 06:08 ginjo

@kmrshntr Is there an update on transfer of rubygems + repo ownership? It's frustrating having this version show up first when its functionality is stale and does not work with the new Slack API. At least having a message pointing to @ginjo 's repo in README would be nice.

yurikoval avatar Dec 05 '20 07:12 yurikoval

Please transfer ownership!

shinypancake avatar Feb 11 '21 06:02 shinypancake

+1 transfer to @ginjo

aguynamedben avatar Feb 15 '21 23:02 aguynamedben

I don't understand, the owner of this gem seemed like he was agreeing on some kind of change, whether it's ownership transfer or deprecation etc. Has nothing been done since then? :'(

niuage avatar Jul 04 '22 08:07 niuage

Hey @kmrshntr, sorry to revive this thread! Is there anyway we can contribute to this repo to get it up to date? thanks!

marcbest avatar Jul 24 '23 22:07 marcbest