django-jenkins
django-jenkins copied to clipboard
Crash when running pylint with pylint version >= 2.0
recent pylint version don't support the exit keyword (and uses do_exit instead)
File "/opt/jenkins/workspace/webservices/env/lib/python3.6/site-packages/django_jenkins/management/commands/jenkins.py", line 116, in handle
coverage.save(tested_locations, options)
File "/opt/jenkins/workspace/webservices/env/lib/python3.6/site-packages/django_jenkins/tasks/run_pylint.py", line 44, in run
lint.Run(args, reporter=ParseableTextReporter(output=output), exit=False)
TypeError: __init__() got an unexpected keyword argument 'exit'
@kmmbvnr can you please take a look?
In the mean time I'm using following monkey patch:
from django_jenkins.tasks import run_pylint
class Lint:
class Run(run_pylint.lint.Run):
def __init__(self, *args, **kwargs):
super().__init__(*args, do_exit=kwargs.pop("exit"), **kwargs)
run_pylint.lint = Lint
@kmmbvnr is there anything we can do to progress this PR? :smiley:
The same problem for django-jenkins 0.110.0 and pylint 2.4.4
Pylint < 2.0 is also not avaible for Python 3.7, so this is really becoming a problem :(