Konstantin Lebedev

Results 219 comments of Konstantin Lebedev
trafficstars

@guo-sj > I wonder if this is what you want? Before I create this PR, I tested so many times, using boto3, aws cli and go test. I don't really...

I have a feeling that the logic will break on the part of s3

Let's add tests right away, shall we? https://github.com/chrislusf/seaweedfs/blob/master/weed/iamapi/iamapi_test.go#L141

> > Let's add tests right away, shall we? > > Sure. What's your test point? for ``` // Parse "arn:aws:s3:::my-bucket/shared/*" and // Parse "arn:aws:s3:::my-bucket/*" // Parse "arn:aws:s3:::my-bucket-prefix-*" ```

> > I have a feeling that the logic will break on the part of s3 > > I don't understand, your feeling? Not any evidence or proof? > >...

``` version: '2' services: master0: image: chrislusf/seaweedfs:local ports: - 9333:9333 - 19333:19333 command: "-v=1 master -volumeSizeLimitMB 100 -raftHashicorp -ip=master0 -port=9333 -peers=master1:9334,master2:9335 -mdir=/data" volumes: - ./master/0:/data environment: WEED_MASTER_VOLUME_GROWTH_COPY_1: 1 WEED_MASTER_VOLUME_GROWTH_COPY_2: 2...

@divanikus You can check? chrislusf/seaweedfs:dev

@divanikus Ping. Plz check chrislusf/seaweedfs:dev

Checked for Seaweed Master 30GB 3.27: ``` make 2clusters server1_1 | I0916 11:19:16.774397 master_server.go:259 adminScripts: lock server1_1 | ec.encode -fullPercent=95 -quietFor=1h server1_1 | ec.rebuild -force server1_1 | ec.balance -force server1_1...

It seems to be correct before creating a new volume to check if there are enough replicas, for example, for the case defaultReplication=999