SpotMenu icon indicating copy to clipboard operation
SpotMenu copied to clipboard

Published 20 hours ago • verified publisher icon kmikiy

Improve playback control button affordance

Open jacobpgn opened this issue 6 years ago • 5 comments

For https://github.com/kmikiy/SpotMenu/issues/12

This adds:

  • button alpha change on hover state
  • more recognisable next/previous icons
  • smaller target areas to make it harder to hit the wrong button

kapture 2018-04-08 at 1 08 33

jacobpgn avatar Apr 08 '18 00:04 jacobpgn

My first time using Xcode and Swift, so I apologise in advance if I've done anything weird here!

jacobpgn avatar Apr 08 '18 00:04 jacobpgn

Thanks for the PR 👌🏻I'll check it as soon as i can

kmikiy avatar Apr 08 '18 21:04 kmikiy

I've updated the size of the next and previous buttons and added a more subtle pressed in state (.leftMouseDown). What do you think?

so I apologise in advance if I've done anything weird here!

No worries. Nothing weird. By the way this whole project could use some refactoring 😬

kmikiy avatar Apr 09 '18 08:04 kmikiy

Pressed in state looks much better now, nice one!

I think the previous button is positioned a few points too high, are you seeing that too?

jacobpgn avatar Apr 10 '18 18:04 jacobpgn

I think the previous button is positioned a few points too high, are you seeing that too?

Could be. The auto guidelines in xcode kept snapping the buttons in position.

I also noticed that the pause icon is a bit fuzzy on the top left and bottom right. I haven’t looked in to why that’s happening. Maybe due to the resolution?

kmikiy avatar Apr 10 '18 19:04 kmikiy