Mikhail Korobov

Results 479 comments of Mikhail Korobov

Yeah, this makes sense. For all other endpoints `http_method` and `body` work as-is, but for Lua script you have to implement it yourselves. HTTP status code is handled for `/execute`...

Hey @atultherajput, Thanks for the fix! It looks like tests are failing because SplashHtmlResponse should be a subclass of SplashTextResponse, like HtmlResponse is a subclass of TextResponse.

@atultherajput it seems this change won't fix https://github.com/scrapy/scrapy/issues/2673 - SplashHtmlResponse in this PR is still not a subclass of HtmlResponse. I think it should be a subclass of both SplashTextResponse...

@redapple I need to refresh my memory and check it again, but as I recall there is an issue with this PR, it didn't solve the problem, and that's why...

@m2jobe I think the problem could be 127.0.0.1 address - Splash is usually executed in a Docker container, and localhost is different from localhost of the spider.

See also: https://github.com/scrapinghub/splash/issues/234

If a proxy is executed in a docker container too then you can use e.g. docker-compose to link these containers. You can have 'splash' and 'proxy' containers, link them, and...

Glad you got it working! Have you figured out what was the problem?

Hey @cp2587, If you're using Lua scripts then headers are not handled automatically. From scrapy-splash readme (`meta['splash']['dont_send_headers']` docs): > by default scrapy-splash passes request headers to Splash in 'headers' JSON...

Awesome! I have some comments, but first question is what do you think about extracting blend modes extension to a separate library (blendosaurus? blend-modes?) We can put it under psd-tools...