Mikhail Korobov

Results 479 comments of Mikhail Korobov

Hey! The problem clearly exists (you're having issues with VSCode and web-poet fixtures). I wanted to clarify some points though. > Right now tests created for page objects aren't [discoverable](https://docs.pytest.org/en/7.1.x/explanation/goodpractices.html#conventions-for-python-test-discovery)...

> It's not about VSCode or any other IDE, it's about how fixtures are organized, these don't follow this [doc](https://docs.pytest.org/en/7.1.x/explanation/goodpractices.html#conventions-for-python-test-discovery) Sorry, I don't agree :) There are test types which...

> Though generally, their code wouldn't break as long as those parameters aren't passed to .to_item(). The code shouldn't break even if scrapy-poet user decides to exclude fields. I.e. we...

I've moved the issue from scrapy-poet issue tracker to web-poet, because web-poet is responsible for this part of the code. The implementation would require some refactoring / rethinking, because currently...

A nice idea to have a documented way to run a single `fixtures//`. As a crude workaround, I think -k argument may work. It also works if one needs to...

Hmm, this may be because I don't unsubscribe before disconnecting. The bad thing is that exception occurred in Client.listen callback was printed to stderr and ignored so I haven't noticed...

I'm still getting None as a message sometimes (with latest master): ``` /Users/kmike/svn/tornadio/tornadio/server.py(71)__init__() 67 except Exception, ex: 68 logging.error('Failed to start Flash policy server: %s', ex) 69 70 logging.info('Entering IOLoop...')...

Btw, ``` self.is_active = False self._call_callbacks(self.callbacks, value) self.is_active = True ``` always seems scary (as well as ExecutionContext.enable and ExecutionContext.disable) because is_active can become incorrect if exception in _call_callbacks occurs...

Yes, sure. Thanks for moving things forward! It now produces this: ``` ERROR:brukva.client:None Traceback (most recent call last): File "/Users/kmike/svn/brukva/brukva/client.py", line 901, in listen data = yield async(self.connection.readline)() GeneratorExit ```

Спасибо, полезная штука!