Mikhail Korobov

Results 479 comments of Mikhail Korobov

@semkath yes, firing a bug there is a good idea.

See also: https://github.com/scikit-learn/scikit-learn/issues/2639#issuecomment-30085346

Yeah, it was also surprising to me that insertions are not O(1) in libdatrie. I think we should add this to the README, at least until there is a fix...

Patricia trie (similar to the Java one) can be found in BioPython.

Hey @hickford, Yes, that'd be nice! I think the way to go is to setup AppVeyor account and upload wheels from there (https://github.com/ogrisel/python-appveyor-demo). Pull requests are welcome! I don't have...

Hello! Unfortunately 256 is a hard limit on alphabet in underlying libdatrie library. It seems that there are missing checks for that both in the wrapper and in the library....

Hi @Honghe, Ways to fix it: 1) Simply make `|alphabet|` larger, i.e. use 2 bytes instead of one - it will change memory requirements of datrie, and it will require...

"Given prefix" defines a node, and items with a given prefix are paths to this node's children from the root of the trie. Do you want a method that returns...

If there is 'aaa' string, but not 'aa', do you want to return 'aa'? Note that in this case 'aa' path also defines a node, and this node is a...

The easiest way would be to just use items which has len(key)==len(prefix)+1. It will give you right items, but will do some unnecessary computations. We may also expose `trie_state_walkable_chars` as...