Kevin Marchais

Results 22 comments of Kevin Marchais

On this branch on my fork [kmarchais/pyvista/pyvista/plotting/plotter.py](https://github.com/kmarchais/pyvista/blob/maint/add-mesh-return-type/pyvista/plotting/plotter.py), I have added return types for almost all other functions except for `show` if you want to use it.

Oh right! Thanks, I have just done it

Hello, thank you very much for your answer. I didn't have time to try it yet but that's what I wanted indeed. For the cylindrical grid, we can imagine a...

I have removed all the return types where were mypy errors. It is still a lot of changes in the same PR though, what do you think?

I don't have much experience with this. I think the most important is to make the history as clear as possible. Also, this PR is mentioned in #6259. Thank you...

Sorry this review request was not intended, I don't understand why all these commits and the review request have been added.

Thank you @adeak, it looks better now. I'm not sure to have managed well the temporary branch though.

Sorry again, I thought I finally found out how to merge main correctly after some tests. But I simply forgot that this PR will not merge into main!

> I could remove the bogus review request, everything back to normal here. Thank you for that and thanks a lot for the help, I will not change anything else!

Hello @manuel-lincbiotech, I took your code and using `clip_scalar` instead of threshold, I got this (clipped on the x plane to see the thickness values inside): ![Image](https://github.com/user-attachments/assets/edcb4918-968b-446b-97f4-16c8eec39f43) Is it what...