Krzysztof Magusiak comments

Results 36 comments of


                                            Krzysztof Magusiak

[FIX] base: added writeable permission check when migrating to filestore

@rco-odoo can you r+ / security

[REF] dev_backend_reports: assets and less

Could you rebase and solve conflicts? Otherwise the PR looks good.

Using python class name corresponding to odoo models

Too big to review, could you make a separate commit for the changes in the ORM?

Using python class name corresponding to odoo models

In fields.py: - Raise `ValidationError` instead of AssertionErrror In models.py: - You don't need to replace all `_inherit` str with lists, the case is still handled.

[IMP] Allow superuser to set log_access fields.

I'm not a fan of context variables, but you could add a context `model_unlock_log_access` boolean with a default of `not self.pool.ready`. @rco-odoo What's your opinion about this?

[MOV] calendar: move unavailable_partner_ids to calendar

> This PR is indeed not about reviewing the whole Interval util lib, we are "only" moving it. > > I understand it's a good opportunity to take a good...