Greg Netsas

Results 1140 comments of Greg Netsas

...meh, still getting `Error: Command failed: phpcs --version` πŸ˜“ 🀷🏼

Test gremlins: https://github.com/backdrop/backdrop-issues/issues/5721

Sorry it has taken so long to notice this @BWPanda ...I'm also supportive of this πŸ‘πŸΌ Can you please do the following?: - rebase the PR to spin up a...

>> add a sanity check for the key being blank/missing > > What do you mean by this @klonos? Other values are allowed: Oops, sorry - I thought that only...

> Can you please file a follow-up for that? Done: #5976 @BWPanda this issue is a feature request, and it is now RTBC. All we need in order to set...

TouchΓ© ...milestone added then πŸ˜‰

Sounds like we should be using `empty()` instead of `count()` ...either that, or a combination of `is_array() && empty()` πŸ€” ...plus also fix those weird things that @indigoxela found with...

Yup, the code change is simple, and no errors logged when creating redirects (plus all tests pass) πŸ‘πŸΌ ...given that we are doing this elsewhere, I'm marking this as WFM...

This is how better_formats goes about it: ![image](https://cloud.githubusercontent.com/assets/2423362/24635874/ab35cfb6-1919-11e7-8d11-0e10db40c620.png) ![image](https://cloud.githubusercontent.com/assets/2423362/24635882/bfd236f8-1919-11e7-80a8-93bbde67f91c.png)