Greg Netsas
Greg Netsas
...meh, still getting `Error: Command failed: phpcs --version` π π€·πΌ
Test gremlins: https://github.com/backdrop/backdrop-issues/issues/5721
Sorry it has taken so long to notice this @BWPanda ...I'm also supportive of this ππΌ Can you please do the following?: - rebase the PR to spin up a...
>> add a sanity check for the key being blank/missing > > What do you mean by this @klonos? Other values are allowed: Oops, sorry - I thought that only...
> Can you please file a follow-up for that? Done: #5976 @BWPanda this issue is a feature request, and it is now RTBC. All we need in order to set...
TouchΓ© ...milestone added then π
Seems reasonable.
Sounds like we should be using `empty()` instead of `count()` ...either that, or a combination of `is_array() && empty()` π€ ...plus also fix those weird things that @indigoxela found with...
Yup, the code change is simple, and no errors logged when creating redirects (plus all tests pass) ππΌ ...given that we are doing this elsewhere, I'm marking this as WFM...
This is how better_formats goes about it:  