Tomasz Kłoczko

Results 2524 comments of Tomasz Kłoczko

OK will check that patch shortly. Thank you :)

Tested that commit and it fixes reported warnings (thank you) however with latest sphinx looks like new warnings started popping up :) ```console + /usr/bin/python3 setup.py build_sphinx -b man --build-dir...

Here is another batch of warnings ```console [tkloczko@devel-g2v pyxattr-0.7.2]$ PYTHONPATH=$PWD/build/$(cd build; ls -d1 lib*) /usr/bin/sphinx-build -n -T -b man doc build/sphinx/man Running Sphinx v4.5.0 loading pickled environment... done building [mo]:...

This PR is not working for me. ```console + PYTHONPATH=/home/tkloczko/rpmbuild/BUILDROOT/python-routes-2.5.1-2.fc35.x86_64/usr/lib64/python3.8/site-packages:/home/tkloczko/rpmbuild/BUILDROOT/python-routes-2.5.1-2.fc35.x86_64/usr/lib/python3.8/site-packages + /usr/bin/pytest -ra --import-mode=importlib =========================================================================== test session starts ============================================================================ platform linux -- Python 3.8.12, pytest-6.2.5, py-1.10.0, pluggy-0.13.1 rootdir: /home/tkloczko/rpmbuild/BUILD/routes-2.5.1 plugins:...

> @kloczek, you seem to either be missing `repoze.lru` dependency or be hitting namespace problems. `` .. yeah. One sec will repeat that wit h added `repoze-lru` to package BuildRequires....

OK I found that already fixed that in my spec file 😋 Updated pytest output ```console + PYTHONPATH=/home/tkloczko/rpmbuild/BUILDROOT/python-routes-2.5.1-3.fc35.x86_64/usr/lib64/python3.8/site-packages:/home/tkloczko/rpmbuild/BUILDROOT/python-routes-2.5.1-3.fc35.x86_64/usr/lib/python3.8/site-packages + /usr/bin/pytest -ra =========================================================================== test session starts ============================================================================ platform linux -- Python...

That patched tests.py uses `nose` which should not be used with python 3.x https://nose.readthedocs.io/en/latest/

It is one very good reason to support pytest. That framework provides way better flexilibily of testing by just install pytest extension. `zope.testrunner` is more and more behind what pytest...

As python 2.x has been EOSed +1.5 year ago I would suggest branch git repo for 2.x support and clean on master everything for latest python 3.x (IIRC in Sep...

Jus tchecked and I've alredy reported that https://github.com/joke2k/faker/issues/1454. Ticket has been closed without fixing the issue 😞