Arsenii Kulikov

Results 72 comments of Arsenii Kulikov

@mattsse hmm, I believe `env.tx.caller` is `tx.origin` and we need `msg.sender` validation here probably?

@CodeSandwich You can already use OKLink for Amoy testnet by passing `--verifier-url 'https://www.oklink.com/api/v5/explorer/contract/verify-source-code-plugin/AMOY_TESTNET'`

this looks great! thanks for implementing this > Currently the error returned from this cheatcode is only catchable with catch (bytes memory) and not with catch Error(string memory). Is there...

3. Yeah, I meant DI approach here, however not sure if it really worth the effort (we would have to somehow pass the mocked `InputSource` all the way down to...

@mds1 Good point. IMO, having a single default value which is used in test environment will not always be enough. I believe that for testing scripts with `prompt` cheats such...

I think it's fine to just have a couple tests like ``` vm._expectCheatcodeRevert("Prompt timed out"); vm.prompt(...); vm._expectCheatcodeRevert("Prompt timed out"); vm.promptSecret(...); ``` we have default timeout set to 0 for testing,...

> if I understood this correctly, then this would be a non issue if we would clear the out folder? what would the layout look like in that case? >...

> all of this is a bit complicated because we support setting the output folder for the profile, and I've seen setups where uses read artifacts from other profile outputs,...

> is the idea to write artifacts always into cache/profile/ and then symlink to the configured out folder? yep, that way we separate cache and artifacts under `cache/{profile}`, but `out`...

> If we want to avoid symlinks, we could just duplicate the output in both places, like literally copy/paste the files from one dir to the other That could work...