Arsenii Kulikov

Results 146 comments of Arsenii Kulikov

> ``` > $ FOUNDRY_PROFILE=via-ir forge build > $ FOUNDRY_PROFILE=test forge test > ``` this would work only if project is only deploying contracts through `deployCode`, otherwise during tests compilation...

> is this a strict requirement for this feature or should we recommend using vm.getCode? using `getCode` is not type-safe and won't work like this if project does not divide...

I think we can now unify `Caller` impls for `WithBlock` and `EthCall`? or maybe just do `impl Caller for WeakClient`?

@yash-atreya one thing I find a bit confusing here is that by design of `Caller` it does not receive more context than a `RequestPacket` we are working with when overriding...

@yash-atreya wondering how do we decide which `Provider` methods return `ProviderCall` vs do `async fn -> TransportResult`?

> Also, any RPC method where we accept a parameter by reference, should be TransportResult since replacing it with ProviderCall will introduce lifetimes. eg. get_fee_history Lifetimes should be fine, we...

> what we could also do is just deserialize the pending block response differently should we add a separate `Network` AT for pending block? like `type PendingBlockResponse: RpcObject + Into`...

> though I would want to confirm to be sure solidity doesn't end up compiling it for some reason if it would be just a standalone file not imported by...

We've discussed this in context of this being useful as a separate crate which we could also pull in as a foundry dep to address https://github.com/foundry-rs/foundry/issues/6228#issuecomment-1812843644 by determining spec for...

> I see, that seems reasonable to me. What do you think @klkvr @mattsse? I think we can add `vm.fail(string)` cheatcode for consistency, I'd prefer to not add methods which...