dojango icon indicating copy to clipboard operation
dojango copied to clipboard

Published 20 hours ago • verified publisher icon klipstein

AMD/async

Open yassam opened this issue 12 years ago • 3 comments

I'm in the process of updating to dojo 1.7.x and and the latest version of dojango (thanks for working on it by the way). I noticed the amd-loader branch but that it hasn't been touched since December.

Do you plan to allow the use of AMD in the master branch any time soon?

yassam avatar Apr 10 '12 22:04 yassam

I've started this branch some months ago and recognized that larger parts of dojango would require a change to support that. If you have an idea how to change it I would be happy getting a pull request :)

I'll go through the branch and will document what is required to support AMD.

klipstein avatar Jun 01 '12 18:06 klipstein

Thanks for replying. I was thinking about doing this but I don't know if I'll get time. I'll let you know if I fork and start working on it.

yassam avatar Jun 05 '12 04:06 yassam

I created a branch that uses AMD: https://github.com/yassam/dojango/tree/dojo-2.0

I haven't created a pull request for it because I don't consider it ready, but it does what I need for my current project:

  • Only the template base.html has been tested
  • I haven't updated any of the tests
  • I've done nothing on the builder code
  • I've tried to maintain backward compatibility, but haven't tested it with older versions of dojo (only 1.8)
  • dojoConfig vs. djConfig - this is configurable via a DOJANGO setting and defaults to dojoConfig for dojo version >= 1.6
  • The use of async loading is also configurable

Feel free to merge into your repo if you think it's worth using (I worked off your AMD branch)

yassam avatar Sep 07 '12 01:09 yassam