rosc icon indicating copy to clipboard operation
rosc copied to clipboard

Published 20 hours ago • verified publisher icon klingtnet

Implement stream encoding

Open klingtnet opened this issue 1 year ago • 0 comments

This adds encode_tcp ~~and fixes a bug when decoding a message that contains multiple packets~~. The implementation is still pretty basic, ideally encode_tcp should accept an Output trait object to encode into.

TODOS

  • [x] The existing decode_tcp function was correct, I think. What I need to verify is, if it's okay to add OSC Packets to an OSC Bundle if the bundle comes first, because that's how the original implementation behaves. Commit https://github.com/klingtnet/rosc/pull/49/commits/53e7144c556e9216d2623de2dd86237e7bf0cbf7 reverts the "fix".
    • I consider the existing decoder implementation correct.
  • [x] Squash fixups.

klingtnet avatar Jun 10 '23 13:06 klingtnet