KLineChart icon indicating copy to clipboard operation
KLineChart copied to clipboard

[Bug] No type definitions for 'klinecharts/lib/mark/shapeHelper'

Open jinusean opened this issue 2 years ago • 3 comments

Version

8.6.1

Steps to Reproduce

image

Current Behavior

Cannot import without // @ts-ignore

Expected Behavior

Type definitions to allow imports.

Environment

- OS:
- Browser:
- Framework:

Any additional comments?

Docs specify using import { ... } from 'klinecharts/lib/mark/shapeHelper', but the correct path is klinecharts/lib/shape/shapeHelper, which also does not have typescript support

jinusean avatar Aug 27 '22 09:08 jinusean

Documentation has some errors.

liihuu avatar Aug 27 '22 15:08 liihuu

Not just the documentation but the typescript support as well.

jinusean avatar Aug 28 '22 10:08 jinusean

I will write the declaration file.

liihuu avatar Aug 28 '22 15:08 liihuu

V9 has been reconstructed with typescript, so don't worry about such problems.

liihuu avatar Jan 10 '23 17:01 liihuu