recalendar.js icon indicating copy to clipboard operation
recalendar.js copied to clipboard

Published 20 hours ago • verified publisher icon klimeryk

feat: add pt-br translations

Open giovana-morais opened this issue 2 years ago • 1 comments

This PR adds Portuguese (pt-br) translation.

I left the [WIP] because I want to give it a second review tomorrow and maybe ask for a friend to review it too.

Thanks for the cool project!

giovana-morais avatar Jul 28 '22 15:07 giovana-morais

@klimeryk I have a question. when I try to use pt-br as the language code, the visualization breaks and I get this error:

i18next::languageUtils: rejecting language code not found in supportedLngs: pt-BR

however when I use pt everything works normally. what do you think is the best? should we keep Brazilian Portuguese as pt?

giovana-morais avatar Aug 04 '22 16:08 giovana-morais

@giovana-morais your proposal would work 100% for Portugal Portuguese (pt-pt) as well. In my opinion, it can be added as just "Portuguese" (or Português).

joaocrebelo avatar Apr 06 '23 17:04 joaocrebelo

Closing as changes have been merged as mentioned in https://github.com/klimeryk/recalendar.js/pull/39#pullrequestreview-1376943171 🙏

klimeryk avatar Apr 09 '23 19:04 klimeryk

hi @klimeryk and @joaocrebelo! thanks for taking some time to review, comment and fix the issue with the language code! for the missing translations, there is no actual missing translations. in Portuguese, "remove" is from the verb "remover". long story short, they are the same in Portuguese and English. (:

giovana-morais avatar Apr 09 '23 20:04 giovana-morais

Hahaha, I did not know that and made assumptions! Sorry I doubted your translation then! 🙇

klimeryk avatar Apr 11 '23 20:04 klimeryk