Can't pull Familiar Rings out of Refined Storage storage

[FoxySophie]

Describe the bug When putting a familiar ring which has a familiar inside into a Refined Storage setup it's not possible to pull it out again via a Grid. You have to use an Exporter to get it out. Rings without familiars inside work fine.

To Reproduce Steps to reproduce the behavior:

1. Craft Familiar Ring and bind a familiar to it, like the Greedy one
2. Put the ring into a Refined Storage setup
3. You can no longer pull it out via Grids, only by using an Exporter

Expected behavior Should be able to pull the ring out just like any other item.

Screenshots

https://github.com/user-attachments/assets/d5149390-8ca9-43d8-889a-0249640dcb92

System (please complete the following information):

• Occultism Version: 1.181.0
• Refined Storage: v2.0.0-beta.2
• OS: Windows 10
• Minecraft Version: 1.21.1
• Modpack Link and Version, or list of mods: https://modrinth.com/modpack/serene-pioneers-season-2

[klikli-dev]

I suspect this is an NBT issue (items with a lot of NBT are not always handled gracefully), or in this case, a data component with a lot of nbt (the captured entity's information). Can you open an issue with refined storage, and link here?

I am not sure if that is something they can fix on their end, or if they need me to do changes on my end, but they might know how to handle it

[FoxySophie]

Refined Storage devs are basically saying they can't/won't fix it on their end.

[Nodrance]

I'm not a dev I'm just a guy who has github access

https://refinedmods.com/refined-storage/items-cannot-be-extracted-from-refined-storage.html#_for_mod_developers

Short answer is refined storage uses equals() and hashCode() to figure out what item the client clicked on and tell that to the server. Some mods (a lot of them) don't implement these properly, so when the client says "get me the item with hashcode a3b7892a", the server doesn't see any item like that and so doesn't take anything out

[Nodrance]

On your end, if you implement those two functions so that the same item always has the same result, things will work

[FoxySophie]

I'm not a dev I'm just a guy who has github access

Sorry for my misunderstanding, and thanks for helping to solve the problem!

[klikli-dev]

Thanks a lot @Nodrance , I will check that!

[klikli-dev]

hmm, I am using only vanilla data components which implement equals and hashCode correctly (namely, they should correctly handle NBT) ... the question is which part causes the issue

[ThePixelatedCat]

Would it be worth referencing other mods with complex nbt that work properly with RS?