Kilian Lieret comments

Results 430 comments of


                                            Kilian Lieret

Black format codebase

ruff formatting is currently not active in pre-commit

fix: use nonblocking reads to avoid unix specific apis

Thanks @cpendery I'll have a closer look in a second, just curious: With these changes, are you able to run the pipeline on Windows? Or does it immediately run into...

fix: use nonblocking reads to avoid unix specific apis

I think it's better to create separate PRs. I'm just trying to get an overview of how difficult it is to get this running on Windows at all (because you...

fix: use nonblocking reads to avoid unix specific apis

@talentoscope According to the documentation it should be since python 3.5: ![image](https://github.com/princeton-nlp/SWE-agent/assets/13602468/61bb481b-5569-4b9e-b872-a93553a7f756)

fix: use nonblocking reads to avoid unix specific apis

Thanks for the follow-up. You seem to have missed an underscore `os.set_blocking`

fix: use nonblocking reads to avoid unix specific apis

Hi @cpendery sorry for the late follow ups. I just tested again on osx and I get ``` DEBUG Starting container with command: docker run -i --rm --name sweagent-swe-agent-latest-e6bd95bd78 sweagent/swe-agent:latest...

fix: use nonblocking reads to avoid unix specific apis

Sorry, could you explain what you mean with "the docker container's logs during execution"? I've checked if there's any additional logs in the Docker desktop app, but they were empty....

fix: use nonblocking reads to avoid unix specific apis

Hi @cpendery , sorry for my slow responses. I have since also run other experiments related to `read_with_timeout` (#230) and got feedback from the rest of the team that this...

fix: use nonblocking reads to avoid unix specific apis

OK, noticing that there are two different things, `signal` and `select`, let's do the following: 1. The `signal` issue can be solved with threads, so let's just do that (rather...

fix: use nonblocking reads to avoid unix specific apis

> Question on this, are you trying to preserve a single shell session between commands? If not, you could just run docker exec commands into the container and wait on...