Klesh Wong

Results 656 comments of Klesh Wong

Hi, @antoniomuso Do you think the PR is ready for review? Please mark it as **Ready For Review** if so. I'm seeing the status of this PR showing **Draft** which...

> > What is the difference between user and account? > > @klesh In this case is no difference; I called GitlabUserAccount because Account just exists, but in reality, this...

> Sorry, Now I start to work on it; I was on vacation. No worry and thanks for your contribution. Please let us know when you are ready, we will...

@antoniomuso Good work, looks good to me overall. Some minor issues you may want to take a look.

LGTM, to be merged after v0.21-beta1 released

Sorry for merging it so late, it has been done.

😂 I find myself falling into the same hole as well. We rely on the feature to implement a bunch of PATCH APIs and they worked nicely for years until...

Please correct me if I am wrong: `shellCommand` could be called by other functions like `eval` which would pass a list of args that would not work when the shell...

Maybe we could add a new option like `shellargsep = "--"` so Non-Posix shell users could set it to empty?

@joelim-work Thanks for the clarification, I believe I understood your comment about the argument shifting. However, `nu` does not ignore the extra arguments and it would throw an error on...