kleros-v2 icon indicating copy to clipboard operation
kleros-v2 copied to clipboard

Refactor/dispute resolver

Open Harman-singh-waraich opened this issue 7 months ago • 6 comments

  • updates Dispute resolver Aliases to be optional

  • updates dispute resolver template types

    • answer.description now mandatory
    • answer.id now saved as hex-string
    • category now mandatory
    • added version field
    • added arbitrableAddress, arbitrableChainId, arbitratorAddress, arbitratorChainId fields

PR-Codex overview

The focus of this PR is to update form validations and default values in the Resolver module.

Detailed summary

  • Updated minimum value for aliases in Resolver form.
  • Added description field validation for voting options.
  • Improved handling of option updates in Resolver form.
  • Updated form validations for voting options and notable persons.
  • Added new imports and type definitions.
  • Enhanced IDisputeTemplate interface with new properties and default values.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • New Features

    • Added version field to dispute templates.
    • Included description fields in answers and aliases for disputes.
  • Enhancements

    • Modified validation for addresses and categories in the NextButton component.
    • Improved validation for dispute templates by requiring both title and description for answers.
  • Bug Fixes

    • Updated min value in NotablePersons parameter to 1 from 2.
  • Refactor

    • Changed variable declarations to const for consistency in OptionsFields component.
    • Updated label for option description input to indicate it is no longer optional.

Harman-singh-waraich avatar Jul 08 '24 12:07 Harman-singh-waraich