kleros-interaction icon indicating copy to clipboard operation
kleros-interaction copied to clipboard

perf(RNG): use strict less on pre-merge check

Open greenlucid opened this issue 2 years ago • 1 comments

saves at least 6 gas. "less or equal" does not exist in the evm as a separate opcode, so to get the same effect, the compiler:

  • does a >, and does a ! on the result.
  • does a <, then a ==, then || both.

both variants need some stack manipulation, and take extra ops. but, you can just to a < check of the immediately larger value.

greenlucid avatar Sep 07 '22 15:09 greenlucid

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Sep 07 '22 15:09 sonarqubecloud[bot]