django_markdown icon indicating copy to clipboard operation
django_markdown copied to clipboard

Published 20 hours ago • verified publisher icon klen

Django 2.0

Open Ge0 opened this issue 7 years ago • 17 comments

Hello there,

Django 2.0 has just been released and the django.core.urlresolvers submodule has been replaced by django.urls. This is a breaking change and we were warned about it since Django 1.7.

The following PR submit snippets that try to import urlresolvers first (for backward compatibility before Django 2.0) then, if it fails, imports django.urls for compatibility with new Django versions.

Ge0 avatar Dec 03 '17 09:12 Ge0

@Ge0 This build is failed because of --use-mirrors has been deprecated.

seenureddy avatar Dec 20 '17 07:12 seenureddy

Oh, is this project alive eventually?

We should fix the CI then. :)

Ge0 avatar Dec 20 '17 08:12 Ge0

I have created the ticket https://github.com/klen/django_markdown/issues/82 to fix this issue.

seenureddy avatar Dec 20 '17 08:12 seenureddy

Hi, I'm upgrading my project to Django 2.0, are you planning a new release fixing this soon?

tomasgarzon avatar Jan 10 '18 16:01 tomasgarzon

I think we have to find another package...

Ge0 avatar Jan 10 '18 16:01 Ge0

any suggestion?

tomasgarzon avatar Jan 10 '18 17:01 tomasgarzon

Not that I have heard recently.

Also, you can still fork the repo, fix the bug and release a django2_markdown pip package. That would help a lot of people for sure, me included!

Ge0 avatar Jan 10 '18 17:01 Ge0

Great! I'll do it!

tomasgarzon avatar Jan 10 '18 17:01 tomasgarzon

Let me know here when it's done!

Ge0 avatar Jan 10 '18 17:01 Ge0

@tomasgarzon Sorry for the delay, but have you taken a look at https://pypi.python.org/pypi/django-markdown-app ?

Ge0 avatar Jan 10 '18 17:01 Ge0

Yes, but it doesn't have django 2.0 support, have the same problem with django.core.urlresolvers

tomasgarzon avatar Jan 11 '18 15:01 tomasgarzon

Sorry, It has support but you should use pip install from git directly.

tomasgarzon avatar Jan 11 '18 15:01 tomasgarzon

Oh I see. Maybe this project is maintained compare to django_markdown.

Ge0 avatar Jan 11 '18 15:01 Ge0

@Ge0 https://github.com/seenureddy/django_markdown fix and merge the broken Travis. Create the PR to the repo?

seenureddy avatar Mar 09 '18 10:03 seenureddy

This repository is abandoned, not sure there is something to do.

Ge0 avatar Mar 09 '18 11:03 Ge0

@Ge0 I see you have updated the fork with Django2.0 here https://github.com/Ge0/django-markdown-gcir. I am thinking to use it because I can't go for other packages as I am working on a legacy project which is required to migrate into Django 2.0+.

I hope there won't be any issue using https://github.com/Ge0/django-markdown-gcir. Please do let me know your thoughts.

Thanks

abdulwahid24 avatar Jul 05 '19 01:07 abdulwahid24

Hey @abdulwahid24

It has been a while since I last used this package. I cannot guarantee that there won’t be any issue at this time.

You’ll might have to modify the package to make it work.

Ge0 avatar Jul 05 '19 13:07 Ge0