twinejs icon indicating copy to clipboard operation
twinejs copied to clipboard

2.3: HTML in Find/Replace passage text preview isn't escaped

Open webbedspace opened this issue 3 years ago • 1 comments
trafficstars

image As you can see, by opening the "AUTHOR NOTES" passage's text preview thingy, some passage text has escaped and migrated to the top of the window. image Here's the opening code of that passage, for reference.

Twine version number

2.3.16

Does this problem occur with the web version of Twine or the desktop app?

Web

What operating system does this problem occur on?

Windows

If this problem is occurring with the web version of Twine, what browser does it occur on?

Firefox

Presubmission checklist

  • [x] I am interested in working on code that would fix this bug. (This is not required to submit a bug report.)
  • [X] I have done a search and believe that an issue does not already exist for this bug in the GitHub repository.
  • [X] I have read and agree to abide by this project's Code of Conduct.

webbedspace avatar Mar 31 '22 14:03 webbedspace

Ah, this makes sense because 2.3 is using HTML to do passage highlighting. Not an issue in 2.4 but I'd accept a PR for the maintenance branch.

klembot avatar Apr 03 '22 22:04 klembot

Closing since find/replace was revamped in 2.4+.

klembot avatar Jan 21 '23 19:01 klembot