transmission-php
transmission-php copied to clipboard
kleiram
Consider adding another maintainer?
Hi @kleiram
I recall from a past issue you mentioned you were swamped at work. There does seem to be some interest from people to contribute fixes, so I wonder if you had considered adding another maintainer to the project who can handle incoming PR's and tag releases?
I'd be happy to fill this role in my open source time, like I do with a few other projects (phpecc, phpasn1), or if you know someone else who could that would be great.
Hi @afk11!
Thanks for opening this issue, and you're entirely correct I don't exactly have time at the moment to properly maintain this library. I've kind of neglected this, which is not good.
How would you suggest we'd handle this?
The main thing is adding another maintainer to manage releases under the existing packagist project.
Sometime making an organization ('transmission-php'?) for it could be good as it allows for more control over contributor permissions, and lets other admins add users without having to poke you then also!
Hello, A fork is here: https://github.com/kleiram/transmission-php/issues/85
Hi @Surfoo, to be honest there are already several forks in personal repos, also with their own modifications.. Moving the repo to another personal org just seems like the same issue can happen over again?
Why not claim transmission-php/transmission-php and add kleiram and maybe myself to the org? Then set up packagist to point to that
edit: One potential plan: push this repo as is to a new transmission-php organization, tweak the composer.json, and then setup that repo on packagist under transmission/transmission. You'll want to publish the most recent tag of kleiram/transmission under the new organization so people have a way to migrate over to the repo without having to fully upgrade the other dependencies too. Then push your work, and tag as the next major version.
Hello @afk11, you are right, I just created the transmission-php organization! I invited you and @kleiram too :)
Nice one! Thanks for adding me
I think its important to preserve the old projects history though: It's looking like a lot of PHP7 changes went into that Initial commit, making them pretty hard to cherry-pick on top of this repo.
I just made a patch between kleiram/transmission-php@master and transmission-php/transmission-php@Initial commit, which I can apply that brings kleiram/transmission-php up to date with your changes - I'll prepare this in a branch somewhere, and we can review later?
Patch file, bringing kleiram/master up to Surfoo/Initial commit. I plan to just cherry-pick in the later commits if possible ab.diff.txt
I've processed the initial commit, and have split out a new commit 'Project modernization: PHP7' with it's changes, based on top of kleirams last commit.
Oh, thanks for your work :) I rebased develop from master and force to keep my modifications.
Hi!
I think this is a good idea since I don't really have the time to maintain this project anymore (as you might have noticed, sorry about that). I think it'd be nice to continue this project though, so I highly support forking this to another organisation to prevent issues like I've caused in the future!
What I think should happen is update the README to point to the new repository and then I'll archive this repository (and on Packagist as well if that is required). If the new project is up and ready I'll also update the Composer file to point to the new repository using the replace key.
Hello kleiram,
First, thanks for your work!
Yes, you can update the readme, and archive this repository. The fork is here now : https://github.com/transmission-php/transmission-php and already on packagist : https://packagist.org/packages/transmission-php/transmission-php
You can abandon the package and use the replace key, it'll be great!