elm-hot-webpack-loader icon indicating copy to clipboard operation
elm-hot-webpack-loader copied to clipboard

Update peer deps

Open simonh1000 opened this issue 3 years ago • 8 comments

The peerDeps declaration conflicts with using elm-webpack-loader on webapck5 systems. But it looks as though your code works perfectly fine with the 8.0.0 and its just the declaration that needs updating

simonh1000 avatar Apr 01 '21 07:04 simonh1000

@klazuka Would you accept a PR for this?

ronanyeah avatar Apr 15 '21 00:04 ronanyeah

Yes, that would be appreciated.

On Wed, Apr 14, 2021 at 8:46 PM Rónán @.***> wrote:

@klazuka https://github.com/klazuka Would you accept a PR for this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/klazuka/elm-hot-webpack-loader/issues/21#issuecomment-819940049, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAUULPSBENXBI5QLCWSIC3TIYZNTANCNFSM42GQWZOQ .

klazuka avatar Apr 15 '21 11:04 klazuka

In progress: https://github.com/ronanyeah/elm-hot-webpack-loader/commit/324969a5a68f7d6d9e684a885e361578ef052221

ronanyeah avatar May 29 '21 21:05 ronanyeah

I got this working in #38

robinheghan avatar Aug 27 '21 07:08 robinheghan

Awesome - everything just worked when you updated all the libs?

simonh1000 avatar Aug 27 '21 07:08 simonh1000

Pretty much. Just had to update the test project so it would work with webpack 5, which took some trial and error.

robinheghan avatar Aug 27 '21 07:08 robinheghan

@klazuka - any plan for the merge? With node 16.x and npm 8 the npm install throws errors that there are incompatible versions in peer-dependencies for elm-hot-webpack-loader and elm-webpack-loader.

Workaround to get around those errors is to use --legacy-peer-deps flag while installing this package

npm install --save-dev --legacy-peer-deps elm-hot-webpack-loader

kraklin avatar Nov 04 '21 15:11 kraklin

I have published this: https://www.npmjs.com/package/elm-reloader Here's an example usage: https://github.com/ronanyeah/elm-webpack

ronanyeah avatar Jun 21 '22 02:06 ronanyeah