xenontrade icon indicating copy to clipboard operation
xenontrade copied to clipboard

Support for Scarab Pricing

Open stephenhoran opened this issue 5 years ago • 5 comments

I attempted to add this support myself however I am unable to really determine the cause of this errors I am receiving. I added the following to parserTypes.json file under the Normal Array:

    {
      "regex": "Can be used in the Templar Laboratory or a personal Map Device to add modifiers to a Map.",
      "type": "Scarab"
    }

As well as extended the API's in the poe ninja api.

      {overview: "item", type: "Scarab"},

However still no luck, just a yellow icon, no errors logging.

Ninja supports: https://poe.ninja/api/data/itemOverview?league=Betrayal&type=Scarab

I will continue to try and hack on this but maybe I am missing something?

stephenhoran avatar Dec 31 '18 18:12 stephenhoran

You need to add the API url to the poe-ninja-module somewhere. I can't check exactly where right now but I'll update in a day or two.

klayveR avatar Jan 01 '19 02:01 klayveR

@klayveR Interesting. I assumed that by updating the API's attribute of the NinjaAPI class in the poe-ninja-module would be enough to make the helper able to build the correct url based on type. I will have to see what you do to implement this to better understand.

stephenhoran avatar Jan 01 '19 18:01 stephenhoran

You're right, just checked again and that should work. Maybe the item isn't being parsed correctly or the query to fetch the price needs to be adjusted for scarabs. I currently only have access to a mobile device so I can't check this properly, but will do once I'm back home.

klayveR avatar Jan 01 '19 21:01 klayveR

@klayveR Yes, very strange. I could not figure out how to log the http request itself as I am pretty new with electron and could not see any http events in the debugger. Thanks for the help! Love the tool, I use it daily!

stephenhoran avatar Jan 01 '19 23:01 stephenhoran

@klayveR it appears this issue has returned in the new league :(

stephenhoran avatar Jul 05 '19 17:07 stephenhoran